Skip to content

Fix finding the standard library for pnpm #7615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

Fix finding the standard library for pnpm #7615

merged 2 commits into from
Jul 9, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jul 8, 2025

Fixes #7526

@cknitt cknitt marked this pull request as draft July 8, 2025 18:02
Copy link

pkg-pr-new bot commented Jul 8, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7615

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7615

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7615

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7615

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7615

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7615

commit: 1d5f8f0

@cknitt cknitt force-pushed the fix-pnpm branch 7 times, most recently from a7f33bd to bcc65cb Compare July 8, 2025 19:28
@cknitt cknitt requested review from cristianoc and Bushuo July 8, 2025 20:09
@cknitt cknitt marked this pull request as ready for review July 8, 2025 20:10
- bin: node_modules/.pnpm/@rescript+darwin-arm64@12.0.0-alpha.13/node_modules/@rescript/darwin-arm64/bin
- stdlib: node_modules/rescript/lib/ocaml (symlink)
*)
| "bin" :: _platform :: "@rescript" :: "node_modules" :: _package :: ".pnpm"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tricky

@cknitt cknitt force-pushed the fix-pnpm branch 2 times, most recently from 74eba50 to 39eb689 Compare July 9, 2025 07:18
@cknitt cknitt merged commit ce6e8ed into master Jul 9, 2025
27 checks passed
@cknitt cknitt deleted the fix-pnpm branch July 9, 2025 07:43
@DZakh
Copy link
Member

DZakh commented Jul 9, 2025

🙏🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

12.0.0-alpha.13: Pervasives not found when using pnpm
4 participants