Skip to content

fix: ignore warning config for non local deps #7614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

Bushuo
Copy link
Collaborator

@Bushuo Bushuo commented Jul 8, 2025

This fixes: #7564
The warning configuration for non-local dependencies is ignored.

Copy link

pkg-pr-new bot commented Jul 8, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7614

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7614

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7614

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7614

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7614

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7614

commit: 81f857f

@Bushuo Bushuo marked this pull request as ready for review July 8, 2025 15:21
@Bushuo Bushuo force-pushed the rewatch-warning-handling branch from 9dfe2a7 to ceca379 Compare July 8, 2025 15:43
@cknitt
Copy link
Member

cknitt commented Jul 8, 2025

Great work, will test tomorrow!

@cknitt
Copy link
Member

cknitt commented Jul 9, 2025

Tested, works fine! 🎉

@cknitt cknitt merged commit 65c599f into master Jul 9, 2025
17 checks passed
@cknitt cknitt deleted the rewatch-warning-handling branch July 9, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewatch: warnings options for dependencies should be ignored
2 participants