Skip to content

Pass existing location to children prop #7540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2025
Merged

Pass existing location to children prop #7540

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41580b0
Pass existing location to children prop
nojaf Jun 6, 2025
e2f9c7a
No sure about this
nojaf Jun 6, 2025
747e4c5
Add changelog entry
nojaf Jun 6, 2025
cd4e819
Update roundtrip tests
nojaf Jun 6, 2025
3fc4841
Revert loc to React.someElement
nojaf Jun 10, 2025
e90cb2f
Merge branch 'master' into jsx-ast-children-loc
nojaf Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert loc to React.someElement
  • Loading branch information
@nojaf
nojaf committed Jun 10, 2025
commit 3fc4841c596e64d70498a2e8c6fb070dcac63b0a
2 changes: 1 addition & 1 deletion compiler/syntax/src/jsx_v4.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ let append_children_prop (config : Jsx_common.jsx_config) mapper
| "react" -> Lident "ReactDOM"
| _generic -> module_access_name config "Elements"
in
Exp.apply ~loc:child.pexp_loc
Exp.apply
(Exp.ident
{txt = Ldot (element_binding, "someElement"); loc = Location.none})
[(Nolabel, mapper.expr mapper child)]
Expand Down
17 changes: 17 additions & 0 deletions tests/analysis_tests/tests-reanalyze/deadcode/expected/deadcode.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@
addValueReference ComponentAsProp.res:12:24 --> ComponentAsProp.res:12:13
addValueReference ComponentAsProp.res:13:16 --> React.res:3:0
addValueReference ComponentAsProp.res:11:14 --> ComponentAsProp.res:6:34
addValueReference ComponentAsProp.res:9:6 --> ComponentAsProp.res:6:12
addValueReference ComponentAsProp.res:10:6 --> ComponentAsProp.res:6:20
addValueReference ComponentAsProp.res:12:24 --> ComponentAsProp.res:12:13
addValueReference ComponentAsProp.res:13:16 --> React.res:3:0
addValueReference ComponentAsProp.res:11:14 --> ComponentAsProp.res:6:34
addTypeReference _none_:1:-1 --> ComponentAsProp.res:6:12
addTypeReference _none_:1:-1 --> ComponentAsProp.res:6:20
addTypeReference _none_:1:-1 --> ComponentAsProp.res:6:34
Expand Down Expand Up @@ -407,6 +412,11 @@
addValueReference Hooks.res:10:29 --> Hooks.res:4:12
addValueReference Hooks.res:10:75 --> Hooks.res:5:7
addValueReference Hooks.res:9:7 --> React.res:7:0
addTypeReference Hooks.res:10:29 --> Hooks.res:1:16
addValueReference Hooks.res:10:29 --> Hooks.res:4:12
addValueReference Hooks.res:10:75 --> Hooks.res:5:7
addValueReference Hooks.res:9:7 --> React.res:7:0
addValueReference Hooks.res:13:54 --> React.res:7:0
addValueReference Hooks.res:13:54 --> React.res:7:0
addValueReference Hooks.res:13:40 --> Hooks.res:5:7
addValueReference Hooks.res:13:26 --> Hooks.res:5:14
Expand All @@ -428,14 +438,21 @@
addTypeReference Hooks.res:29:66 --> Hooks.res:1:16
addValueReference Hooks.res:29:66 --> Hooks.res:29:14
addValueReference Hooks.res:29:34 --> React.res:7:0
addTypeReference Hooks.res:29:66 --> Hooks.res:1:16
addValueReference Hooks.res:29:66 --> Hooks.res:29:14
addValueReference Hooks.res:29:34 --> React.res:7:0
addTypeReference _none_:1:-1 --> Hooks.res:29:14
addRecordLabelDeclaration vehicle Hooks.res:33:16 path:+Hooks.Inner.Inner2.props
addRecordLabelDeclaration vehicle Hooks.res:33:16 path:+Hooks.Inner.Inner2.props
addTypeReference Hooks.res:33:68 --> Hooks.res:1:16
addValueReference Hooks.res:33:68 --> Hooks.res:33:16
addValueReference Hooks.res:33:36 --> React.res:7:0
addTypeReference Hooks.res:33:68 --> Hooks.res:1:16
addValueReference Hooks.res:33:68 --> Hooks.res:33:16
addValueReference Hooks.res:33:36 --> React.res:7:0
addTypeReference _none_:1:-1 --> Hooks.res:33:16
addValueReference Hooks.res:39:25 --> React.res:3:0
addValueReference Hooks.res:39:25 --> React.res:3:0
addTypeReference Hooks.res:47:2 --> Hooks.res:1:16
addValueReference Hooks.res:45:4 --> Hooks.res:45:31
addTypeReference Hooks.res:47:14 --> Hooks.res:1:16
Expand Down
Loading