Skip to content

Support doc comment before variant #7535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 16, 2025
Merged

Support doc comment before variant #7535

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
df85b05
WIP
shulhi May 31, 2025
9cb1d26
Format doc comment before bar
shulhi May 31, 2025
4cfae9d
Adjust loc
shulhi May 31, 2025
d90616e
Update test files
shulhi Jun 3, 2025
5649bc8
Lookahead if we are in variant
shulhi Jun 3, 2025
6e01830
Cleanup
shulhi Jun 3, 2025
44786dd
Remove loc adjustment hack
shulhi Jun 4, 2025
97a6748
Update test files
shulhi Jun 4, 2025
372d90a
Update CHANGELOG
shulhi Jun 4, 2025
de54923
Resolve review feedback
shulhi Jun 4, 2025
c23f36b
Update tests
shulhi Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tests
  • Loading branch information
@shulhi
shulhi committed Jun 16, 2025
commit c23f36b3dcaeeebcc1cad128f5e69ace1a401992
3 changes: 0 additions & 3 deletions tests/syntax_benchmarks/data/Napkinscript.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1926,15 +1926,12 @@ module Grammar = {
| PatternList
| PatternOcamlList
| PatternRecord

| TypeDef
| TypeConstrName
| TypeParams
| @live TypeParam
| PackageConstraint

| TypeRepresentation

| RecordDecl
| ConstructorDeclaration
| ParameterList
Expand Down