-
Notifications
You must be signed in to change notification settings - Fork 471
Add throw
#7346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add throw
#7346
Changes from 8 commits
835efe4
0061043
54a06c9
ad6cd69
69ebdca
cad9455
98cc917
86ee1d1
9a4c60b
cafdbed
aa214cd
3de6771
86860f1
263f9fd
b29c903
518bb75
a36b71d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/* Exceptions */ | ||
external raise: exn => 'a = "%raise" | ||
external throw: exn => 'a = "%raise" | ||
|
||
/* Debugging */ | ||
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we add It has the same content as https://github.com/rescript-lang/rescript/blob/master/runtime/Stdlib_Error.res There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it doesn't have exactly the same content though, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will explore this in another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole comment is obsolete and should be removed as there is no
others
folder anymore (leftover from the old stdlib build procedure).Or actually, there should be a module-level doc comment (
/***
) instead explaining what the Pervasives module is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment removed a36b71d