Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit f(undefined) when passing unit (). #6459

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Don't emit f(undefined) when passing unit (). #6459

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbaaea8
RFC: don't emit f(undefined)
cristianoc Oct 30, 2023
e686ac7
Track when undefined is coming from `()`.
cristianoc Oct 31, 2023
f0f0202
isUnit
cristianoc Oct 31, 2023
e5b2315
Update CHANGELOG.md
cristianoc Oct 31, 2023
110454c
Update jscomp/core/js_dump.ml
cristianoc Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG.md
  • Loading branch information
@cristianoc
cristianoc committed Oct 31, 2023
commit e5b2315b04a7206b9d277a03828ebf7f25b00b90
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
- Add [`Deno`](https://deno.land/api?s=Deno) to reserved names, so that modules named `Deno` don't clash with the globally exposed `Deno` object. https://github.com/rescript-lang/rescript-compiler/pull/6428
- Disable ESLint/TSLint on gentype outputs properly. https://github.com/rescript-lang/rescript-compiler/pull/6442
- Improve `rescript` CLI to use `stdout`/`stderr` appropriately for help command's message. https://github.com/rescript-lang/rescript-compiler/pull/6439
- Generate `f()` instead of `f(undefined)` for `f()` https://github.com/rescript-lang/rescript-compiler/pull/6459

# 11.0.0-rc.4

Expand Down