Convert Belt sources to .res #6271
Conversation
|
what does "cleanup of docstrings" mean in particular? |
|
@ryyppy I resolved all the issues with the doc comments, the PR is ready to go. |
| function preprocessorNinjaSync() { | ||
| var cppoNative = ` | ||
| ${cppoRule()} | ||
| ${cppoRule("-n")} |
There was a problem hiding this comment.
Prevent generating lines like
# 1 "others/hashmap.cppo.res"which the ReScript parser does not like.
There was a problem hiding this comment.
This is awesome!
At some point we said we want to get rid of the cppo stuff, since A) the cppo-ed modules aren't really that common to be used and B) we'll probably never change them ever again after rescript-core has been established — but really nice you could maintain the current state with .res.
The format of the docstrings is probably not perfect, but we'll fix that as we try to extract the docstrings for the v11 docs.
|
The one thing that cppo blocks right now is formatting. |
This converts the Belt sources, including the .cppo files, to .res/.resi.
I have left the converted files as they are - may I leave the cleanup of the docstrings to @ryyppy?