Skip to content

Clean up jsx ppx (just a refactor) #6035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 5, 2023
Merged

Clean up jsx ppx (just a refactor) #6035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f963120
Clean up jsx ppx: unused mapper in signature.
cristianoc Mar 5, 2023
b8f7325
Clean up check for multiple react components.
cristianoc Mar 5, 2023
36ab748
Rename items.
cristianoc Mar 5, 2023
28a3ddb
Clean up toplevel processing of bidnings.
cristianoc Mar 5, 2023
762dd55
Move out modifiedBinding
cristianoc Mar 5, 2023
0219ecf
Move out vbMatch
cristianoc Mar 5, 2023
51e5131
Move out mapBinding
cristianoc Mar 5, 2023
7eefea5
Cleanup: mapBinding returns a single binding.
cristianoc Mar 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions res_syntax/src/reactjs_jsx_ppx.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ let getMapper ~config =
| Psig_attribute attr -> processConfigAttribute attr config
| _ -> ());
let item = default_mapper.signature_item mapper item in
if config.version = 3 then transformSignatureItem3 mapper item
else if config.version = 4 then transformSignatureItem4 mapper item
if config.version = 3 then transformSignatureItem3 item
else if config.version = 4 then transformSignatureItem4 item
else [item])
items
|> List.flatten
Expand Down
2 changes: 1 addition & 1 deletion res_syntax/src/reactjs_jsx_v3.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,7 @@ let jsxMapper ~config =
| _ -> [item]
in

let transformSignatureItem _mapper item =
let transformSignatureItem item =
match item with
| {
psig_loc;
Expand Down
Loading