Use Object.prototype.hasOwnProperty.call(a, b) instead of a.hasOwnProperty(b) #5358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty(b) Signed-Off-By: Claire E. Neveu <claire@therecount.com>
ClaireNeveu
force-pushed
the
claire/fix-object-equality
branch
from
101a391 to
f51067a
Compare
|
@ClaireNeveu Sorry I was on leave for several months. Would you add some comment why it makes a difference? |
ClaireNeveu
force-pushed
the
claire/fix-object-equality
branch
from
cd6120e to
ca1e589
Compare
|
@bobzhang I added a comment to the new external declaration explaining why it's necessary to call the function directly instead of via the prototype chain. |
|
@bobzhang Thank you for getting this merged in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5357
This is my first contribution to the project so apologies if I've checked in the wrong files or there is some other changes that need to be made. Let me know and I'll adjust the PR accordingly.