Skip to content

Adapt ninja config to use react ppx from upstream syntax submodule #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 25, 2020
Merged

Adapt ninja config to use react ppx from upstream syntax submodule #4660

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72a7bf5
adapt ninja config to use react ppx from upstream syntax submodule
jchavarri Aug 31, 2020
6516db5
Merge branch 'master' into adapt-build-to-react-ppx-in-syntax
jchavarri Oct 23, 2020
94e3b76
update with latest syntax submodule
jchavarri Oct 23, 2020
9069f7c
add napkin as deps for compiler
jchavarri Oct 24, 2020
b967284
roll back gitmodules change
jchavarri Oct 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
branch = master
[submodule "ninja"]
path = ninja
url = git@github.com:rescript-lang/ninja.git
url = https://github.com/rescript-lang/ninja
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have issue with git protocol?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't. But I didn't have ssh key configured in the terminal I was using, and updating this submodule failed.

I thought using https would remove one barrier for contributors and I saw other submodules were using it, but can roll this back if needed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's maybe keep it as it was, to minimize the diff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ignore = untracked
Loading