Skip to content

Fix escaped backtick highlighting in string literal (#324) #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2022
Merged

Fix escaped backtick highlighting in string literal (#324) #325

merged 2 commits into from
Jan 19, 2022

Conversation

@tsnobip
Copy link
Member

@tsnobip tsnobip commented Dec 2, 2021 •
edited
Loading

should fix #324:

let regex = `\``

let foo = 10

Should I first create a PR in rescript-lang/rescript-sublime?

@tsnobip
Fix escaped backtick in string literal (rescript-lang#324)
1710b6e 
should fix rescript-lang#324:
```
let regex = `\``

let foo = 10
```
@tsnobip tsnobip changed the title Fix escaped backtick in string literal (#324) Fix escaped backtick highlighting in string literal (#324) Dec 23, 2021
cristianoc
cristianoc reviewed Jan 19, 2022
View reviewed changes
@cristianoc
Copy link
Collaborator

cristianoc commented Jan 19, 2022

Thanks!

@cristianoc cristianoc merged commit 9fbfbf9 into rescript-lang:master Jan 19, 2022
@cristianoc cristianoc mentioned this pull request Jan 20, 2022
Closed
cristianoc added a commit that referenced this pull request Jan 20, 2022
@cristianoc
Fix issue with highlighting of templates.
7f12aa0 
Fix issue with highlighting of templates introduced in #325

and reported in

#345
@cristianoc cristianoc mentioned this pull request Jan 20, 2022
Merged
cristianoc added a commit that referenced this pull request Jan 20, 2022
@cristianoc
Fix issue with highlighting of templates.
a4e40e7 
Fix issue with highlighting of templates introduced in #325

and reported in

#345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristianoc cristianoc cristianoc left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

broken syntax highlighting when escaping a backtick in string literal

2 participants

@tsnobip @cristianoc