Skip to content

Fix key prop type #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 23, 2022
Merged

Fix key prop type #74

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5e09771
fix-key-type
mununki Oct 21, 2022
10f6400
rename jsx binding
mununki Oct 22, 2022
9b0fe1b
fix key type for ReactDOM jsx runtime
mununki Oct 22, 2022
adc1a55
update changelog
mununki Oct 22, 2022
2f48356
add key imperatively
mununki Oct 23, 2022
3f0f2e9
Revert "add key imperatively"
mununki Oct 23, 2022
234798b
change jsx runtime binding
mununki Oct 23, 2022
b8fa0f3
update changelog
mununki Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "add key imperatively" 
This reverts commit 2f48356.
  • Loading branch information
@mununki
mununki committed Oct 23, 2022
commit 3f0f2e969746300968a3a8ac3cc25f8b91dc716f
10 changes: 6 additions & 4 deletions src/React.bs.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 13 additions & 8 deletions src/React.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,20 @@ type component<'props> = Jsx.component<'props>

let component = Jsx.component

%%private(
@inline
let addKeyProp = (~key: option<string>=?, p: 'props): 'props =>
switch key {
| Some(key) => Obj.magic(Js.Obj.assign(Obj.magic(p), {"key": key}))
| None => p
}
)

@module("react")
external createElement: (component<'props>, 'props) => element = "createElement"

let createElementWithKey = (~key=?, component, props) => {
let _ = Obj.magic(props)["key"] = key
createElement(component, props)
}
let createElementWithKey = (~key=?, component, props) =>
createElement(component, addKeyProp(~key?, props))

@module("react")
external cloneElement: (element, 'props) => element = "cloneElement"
Expand All @@ -32,10 +39,8 @@ external isValidElement: 'a => bool = "isValidElement"
external createElementVariadic: (component<'props>, 'props, array<element>) => element =
"createElement"

let createElementVariadicWithKey = (~key=?, component, props, elements) => {
let _ = Obj.magic(props)["key"] = key
createElementVariadic(component, props, elements)
}
let createElementVariadicWithKey = (~key=?, component, props, elements) =>
createElementVariadic(component, addKeyProp(~key?, props), elements)

@module("react/jsx-runtime")
external jsxNotKeyed: (component<'props>, 'props) => element = "jsx"
Expand Down