Skip to content

Update Js.String[2].match_ return type #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 18, 2022
Merged

Update Js.String[2].match_ return type #559

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
388be3e
Update Js.String[2].match_ return type
weakish Sep 18, 2022
543cbc3
Update test-examples to test against 10.0.0
weakish Sep 18, 2022
2481a27
update examples to 10.0.0
weakish Sep 18, 2022
3cb0a25
Ignore generated files via test example script
weakish Sep 18, 2022
0a8d9d0
markdown formatting for api/js/string[2]
weakish Sep 18, 2022
dec5b5f
fixup! Update Js.String[2].match_ return type
weakish Sep 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test-examples to test against 10.0.0
  • Loading branch information
@weakish
weakish committed Sep 18, 2022
commit 543cbc310e7b98ef7583ec2a41b2a4cd4222ec63
19 changes: 19 additions & 0 deletions compilers/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion compilers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"dependencies": {
"rescript-820": "npm:bs-platform@8.2.0",
"rescript-902": "npm:bs-platform@9.0.2",
"rescript-912": "npm:rescript@9.1.2"
"rescript-912": "npm:rescript@9.1.2",
"rescript-1000": "npm:rescript@10.0.0"
}
}
4 changes: 2 additions & 2 deletions scripts/test-examples.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ let tempFileNameRegex = /_tempFile\.res/g
// see the package.json on how to define another rescript version
let compilersDir = path.join(__dirname, "..", "compilers")

let bsc = path.join(compilersDir, 'node_modules', 'rescript-912', process.platform, 'bsc.exe')
let bsc = path.join(compilersDir, 'node_modules', 'rescript-1000', process.platform, 'bsc.exe')

const prepareCompilers = () => {
if (fs.existsSync(bsc)) {
Expand Down Expand Up @@ -82,7 +82,7 @@ glob.sync(__dirname + '/../pages/docs/manual/latest/**/*.mdx').forEach((file) =>
try {
// -109 for suppressing `Toplevel expression is expected to have unit type.`
// Most doc snippets do e.g. `Belt.Array.length(["test"])`, which triggers this
child_process.execFileSync(bsc, ['-i', tempFileName, '-w', '-109'], {stdio: 'pipe'})
child_process.execFileSync(bsc, [tempFileName, '-w', '-109'], {stdio: 'pipe'})
} catch (e) {
process.stdout.write(postprocessOutput(file, e))
success = false
Expand Down