Skip to content

fix navigation react version #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix navigation react version #1070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/common/Constants.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ let nextVersion =
let stdlibVersions =
versions.latest === "v11.0.0" ? [latestVersion] : [("v11.0.0", "v11"), latestVersion]

let allReactVersions = [("latest", "v0.12.0"), ("v0.11.0", "v0.11.0"), ("v0.10.0", "v0.10.0")]
let latestReactVersion = "v0.12.0"
let allReactVersions = [
("latest", latestReactVersion),
("v0.11.0", "v0.11.0"),
("v0.10.0", "v0.10.0"),
]

let dropdownLabelNext = "--- Next ---"
let dropdownLabelReleased = "--- Released ---"
Expand Down
4 changes: 1 addition & 3 deletions src/components/Navigation.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,9 @@ module MobileNav = {
let make = (~fixed=true, ~isOverlayOpen: bool, ~setOverlayOpen: (bool => bool) => unit) => {
let router = Next.Router.useRouter()
let route = router.route
let url = router.route->Url.parse
let verionFromUrl = url->Url.getVersionString

let version = Url.getVersionFromStorage(Manual)->Option.getOr(Constants.versions.latest)
let reactVersion = Url.getVersionFromStorage(React)->Option.getOr(verionFromUrl)
let reactVersion = Url.getVersionFromStorage(React)->Option.getOr(Constants.latestReactVersion)

let toggleOverlay = () => {
setOverlayOpen(prev => !prev)
Expand Down