Remove unused raise_kind #6959
Open
Remove unused raise_kind #6959
+13
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DZakh
commented
Aug 17, 2024
Comment on lines
+321
to
+322
| ("%reraise", Praise); | ||
| ("%raise_notrace", Praise); |
There was a problem hiding this comment.
We can also remove these two lines, but it'll be a breaking change.
There was a problem hiding this comment.
I only see those used in some tests, and %raise_notrace in Pervasives. I guess we can remove them there?
We'll need to clean up Pervasives anyway for v12.
There was a problem hiding this comment.
Should I remove them?
There was a problem hiding this comment.
I would say yes - do you agree @cristianoc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up after dropping support of OCaml backend