Skip to content

Commit

Permalink
Test: see what removing opaqueFullApply does
Browse files Browse the repository at this point in the history
The effect is that a bunch of applications are treated as curried applications.
  • Loading branch information
cristianoc committed Jul 24, 2024
1 parent 1d46abe commit f603cf1
Show file tree
Hide file tree
Showing 330 changed files with 5,054 additions and 5,567 deletions.
2 changes: 1 addition & 1 deletion jscomp/core/lam_compile.ml
Original file line number Diff line number Diff line change
Expand Up @@ -1538,7 +1538,7 @@ and compile_prim (prim_info : Lam.prim_info)
(*
either a getter {[ x #. height ]} or {[ x ## method_call ]}
*)
assert (not setter);
(* assert (not setter); *)
match
compile_lambda { lambda_cxt with continuation = NeedValue Not_tail } obj
Expand Down
4 changes: 2 additions & 2 deletions jscomp/ml/typecore.ml
Original file line number Diff line number Diff line change
Expand Up @@ -2159,7 +2159,7 @@ and type_expect_ ?type_clash_context ?in_function ?(recarg=Rejected) env sexp ty
exp_type;
exp_attributes = [];
exp_env = env } in
let apply_internal name e =
let _apply_internal name e =
let lid:Longident.t = Ldot (Ldot (Lident "Js", "Internal"), name) in
let (path, desc) = Env.lookup_value lid env in
let id = mk_exp (Texp_ident(path, {txt=lid; loc=Location.none}, desc)) desc.val_type in
Expand All @@ -2178,7 +2178,7 @@ and type_expect_ ?type_clash_context ?in_function ?(recarg=Rejected) env sexp ty
| _ -> false in

if fully_applied && not is_primitive then
rue (apply_internal "opaqueFullApply" (mk_apply funct args))
rue (mk_apply funct args)
else
rue (mk_apply funct args)
| Pexp_match(sarg, caselist) ->
Expand Down
3 changes: 2 additions & 1 deletion jscomp/test/DerivingAccessorsCurried.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion jscomp/test/DerivingAccessorsUncurried.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions jscomp/test/Import.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 19 additions & 24 deletions jscomp/test/UncurriedAlways.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion jscomp/test/UncurriedExternals.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions jscomp/test/UntaggedVariants.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions jscomp/test/a_filename_test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions jscomp/test/a_recursive_type.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions jscomp/test/a_scope_bug.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 17 additions & 9 deletions jscomp/test/ari_regress_test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion jscomp/test/arith_lexer.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit f603cf1

Please sign in to comment.