Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the upper bound constraint on python version #7949

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 30, 2024

What

We previously had this constraint in place to avoid certain edge cases of users not being able to install Rerun and not understanding why due to transitive deps. Primarily on pyarrow.

I've confirmed pyarrow is now doing something similar in their own project:
https://github.com/apache/arrow/blob/main/python/pyproject.toml#L37

Let's try to let the package solver do the right thing and only add a max-version if we find we are truly incompatible with some future python version.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

We previously had this constraint in place to avoid certain edge cases
of users not being able to install Rerun and not understanding why due
to transitive deps. Primarily on pyarrow.

I've confirmed pyarrow is now doing something similar in their own
project:
https://github.com/apache/arrow/blob/main/python/pyproject.toml#L37

Let's try to let the package solver do the right thing and only add a
max-version if we find we are truly incompatible with some future python
version.
Copy link

Deployed docs

Commit Link
ad233f7 https://landing-3iyh1uep1-rerun.vercel.app/docs

@hgaiser
Copy link

hgaiser commented Oct 30, 2024

Interestingly packages like pytorch don't list an upper limit, even though they are not always compatible with the latest python.

https://github.com/pytorch/pytorch/blob/6e85266a47908c917fe7bcf7d2b837711a1f1cab/setup.py#L1509

pytorch/pytorch#130249

@jleibs jleibs merged commit bf3ddab into main Oct 30, 2024
41 checks passed
@jleibs jleibs deleted the jleibs/python_unleashed branch October 30, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants