Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CpuMesh.albedo_factor overwriting #7914

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

EtaLoop
Copy link
Contributor

@EtaLoop EtaLoop commented Oct 28, 2024

What

If Asset3D.albedo_factor isn't specified, CpuMesh.albedo_factor will always be set to re_renderer::Rgba::WHITE.
However, in some cases CpuMesh.albedo_factor may contain a color that we don't want to be overwritten.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk requested a review from Wumpf October 29, 2024 12:11
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! Should have noticed this in the PR review. Thanks for following up! While we're on it, can you please also fix the other bug pointed out in the comment

crates/viewer/re_space_view_spatial/src/mesh_loader.rs Outdated Show resolved Hide resolved
@EtaLoop EtaLoop requested a review from Wumpf October 29, 2024 15:41
@Wumpf Wumpf added 🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 29, 2024
@Wumpf Wumpf merged commit 5fe43f7 into rerun-io:main Oct 29, 2024
33 of 35 checks passed
@EtaLoop EtaLoop deleted the fix-asset3d-albedo-factor branch October 30, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants