Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-only video support #7261

Merged
merged 49 commits into from
Aug 29, 2024
Merged

Web-only video support #7261

merged 49 commits into from
Aug 29, 2024

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Aug 23, 2024

What

  • Adds web-only video decoding functionality
    • Supported container formats: mp4
    • Supported encoding formats: av1

Proof of concept, much polish needed here (grep for TODO(jan) in this PR).

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

Testing

(EDIT by emilk)

@jprochazk jprochazk changed the title temp Web-only video support Aug 23, 2024
Copy link

github-actions bot commented Aug 23, 2024

Deployed docs

Commit Link
a202f1b https://landing-3wql99v34-rerun.vercel.app/docs

crates/viewer/re_space_view_spatial/src/video_cache.rs Outdated Show resolved Hide resolved
crates/viewer/re_space_view_spatial/src/video_cache.rs Outdated Show resolved Hide resolved
crates/viewer/re_renderer/src/renderer/video.rs Outdated Show resolved Hide resolved
crates/viewer/re_renderer/src/renderer/video.rs Outdated Show resolved Hide resolved
crates/viewer/re_renderer/src/renderer/video.rs Outdated Show resolved Hide resolved
crates/viewer/re_renderer/src/renderer/video.rs Outdated Show resolved Hide resolved
@emilk emilk linked an issue Aug 27, 2024 that may be closed by this pull request
3 tasks
@emilk emilk removed a link to an issue Aug 27, 2024
3 tasks
@jprochazk jprochazk added exclude from changelog PRs with this won't show up in CHANGELOG.md 🕸️ web regarding running the viewer in a browser labels Aug 27, 2024
@jprochazk
Copy link
Member Author

jprochazk commented Aug 27, 2024

@jprochazk
Copy link
Member Author

You can test with this video: https://github.com/rerun-io/video-decode-test/blob/main/data/bbb_video_av1_frag.mp4
Any AV1-encoded MP4 should work, though

@emilk
Copy link
Member

emilk commented Aug 28, 2024

You can test with this video: rerun-io/video-decode-test@main/data/bbb_video_av1_frag.mp4 Any AV1-encoded MP4 should work, though

Nice! I've pushed a commit that allows me to play the video with

pixi run rerun-web video.mp4

@jprochazk jprochazk merged commit 149d913 into main Aug 29, 2024
40 checks passed
@jprochazk jprochazk deleted the jan/unbox-mp4 branch August 29, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants