-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web-only video support #7261
Merged
Merged
Web-only video support #7261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed docs
|
emilk
reviewed
Aug 26, 2024
This was referenced Aug 26, 2024
3 tasks
3 tasks
jprochazk
added
exclude from changelog
PRs with this won't show up in CHANGELOG.md
🕸️ web
regarding running the viewer in a browser
labels
Aug 27, 2024
You can test with this video: https://github.com/rerun-io/video-decode-test/blob/main/data/bbb_video_av1_frag.mp4 |
Nice! I've pushed a commit that allows me to play the video with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exclude from changelog
PRs with this won't show up in CHANGELOG.md
🕸️ web
regarding running the viewer in a browser
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
mp4
av1
Proof of concept, much polish needed here (grep for
TODO(jan)
in this PR).Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.Testing
(EDIT by emilk)
pixi run rerun-web bbb_video_av1_frag.mp4