Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine re_types integration tests into one test target. #7250

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

kpreid
Copy link
Collaborator

@kpreid kpreid commented Aug 21, 2024

What

This significantly reduces (re)build times and total artifact size for these tests as a whole; the combined target is only ~4 times bigger (in time and space) than each of the 19 single-archetype test targets it replaces.

A disadvantage is that now tests/types/main.rs needs to list child modules. If desired, this could be added to the code generator; the cfgs in main.rs could equally well be moved inside each module to make the file completely regular.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

This significantly reduces (re)build times and total artifact size
for these tests as a whole.

A disadvantage is that now `tests/types/main.rs` needs to list child
modules. If desired, this could be added to the code generator; the
`cfg`s in `main.rs` could equally well be moved inside each module
to make the file completely regular.
@kpreid kpreid added 🧑‍💻 dev experience developer experience (excluding CI) ⏱ build-times compilation times exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 21, 2024
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@emilk emilk merged commit 84bd533 into rerun-io:main Aug 21, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ build-times compilation times 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants