-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify spatial picking & fix "3d in 2d" picking #663
Conversation
… with image coordinates
First impressions after trying this out on different datasets:
23-01-04_10.20.33.patched.mp4 |
Bug! I'll investigate. I think also that rectangles might not be double sided 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the zoom issue from my earlier comment: 👍
8310949
to
d6bc41a
Compare
This pr unified previously separate picking detection by introducing a more sophisticated, 3d based picking handling which is also aware of transparency.
Apart from being a necessary code cleanup this also fixes picking of 3d objects in 2d (which were made possible in #625) and allows to pick images in 3d with full zoomed in mini-view just like in 2d:
picking.mov
Even transparent images work in 3d just the same now!
Screen.Recording.2023-01-03.at.16.03.08.mov
Also paves the way for unifying 2d/ortho and 3d cameras in the viewer which will later allow fancy transitions from ortho to 3d (and simplify our code), but doesn't go very far there other than allowing
Eye
to not have a fov.Other known behavior changes:
Missing:
Checklist
CHANGELOG.md
(if this is a big enough change to warrant it)