-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.12 #4146
Conversation
Hi, any plans to merge this or are you waiting for the pytorch test dep? thanks! |
PyTorch is still not released for python 3.12 sadly, but apparently the nightly works. Maybe we could have test work by updating our
EDIT: ☝🏻 that doesn't work ( |
That would be great, if you're open to it. My env requires pyarrow >= 14 and I've been eagerly waiting to integrate rerun (having tested in a separate env) |
…sion to install nightly on 3.12
59cd5d9
to
9b4b5b9
Compare
I could get |
What
I added a bunch of fixes to
scripts/run_all.py
, which has a marked tendency to bit rot:scripts/run_all.py
from bit-rotting #4710Some workaround introduced to deal with PyTorch not 3.12 ready, see:
torch
andtorch vision
python 3.12 gating when PyTorch is 3.12-compatible #4704TODO:
nox -s tests-3.12
passingnox -s run_all-3.12 --save
passingnox -s roundtrips-3.12
passingChecklist