-
Notifications
You must be signed in to change notification settings - Fork 610
Add redap tests for dataframe pushdown #12285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
timsaucer
wants to merge
10
commits into
main
Choose a base branch
from
tsaucer/pushdown-redap-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
2b4d400 to
a720fde
Compare
…to collect results.
…en both static and dynamic exist
c792a8a to
2c85318
Compare
Member
Author
|
Since I ended up with a fair amount of scope creep on this PR, I'm going to open another one with just the updates to the OSS server and existing tests. Then this PR will rebase with only the new tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exclude from changelog
PRs with this won't show up in CHANGELOG.md
OSS-server
🔨 testing
testing and benchmarks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow on work to #12147 .
This adds explicit tests to see what data come back from our push down filters.
The difference between this and the e2e tests is that the e2e tests will check the result of the full output from datafusion collection. That will go through the FilterExec after our table provider, so the data filtered could be done by datafusion rather than our table provider.
We cannot mark our table provider as
Exactbecause it will send back chunks that have more data than was requested.This test will get record batches directly from our table provider without going through any of the other mechanisms of DataFusion. We can verify we get exactly the chunks we expect from the server and no more.
In addition to these checks I am adding a client util. Since the
TableProviderrequires aConnectionClientwe need a little more than just the server hook.Also I updated one method in the
TableProviderthat removes ablock_oncall that makes integration with testing difficult.