Skip to content

Conversation

@emilk
Copy link
Member

@emilk emilk commented Jun 8, 2025

What

Make sure we tests the look of the selection panels for our different view classes.

Looking at the screenshots we can see a lot of room for improvement.

@emilk emilk added 🔨 testing testing and benchmarks ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jun 8, 2025
@github-actions
Copy link

github-actions bot commented Jun 8, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
ff09cf0 https://rerun.io/viewer/pr/10161 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! This should give the next person changing anything related to view properties a good idea of the consequences!

A bit unfortunate how much a lot of these uis relies on having a frame run to show something.
Would also be interesting to expand all of those 🤔

@Wumpf Wumpf merged commit ab0656a into main Jun 9, 2025
46 of 47 checks passed
@Wumpf Wumpf deleted the emilk/more-snapshot-tests branch June 9, 2025 11:36
emilk added a commit that referenced this pull request Jun 9, 2025
### Related
* Following #10146
* which merge-raced ahead of
#10161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks ui concerns graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants