Re-establish example requirements.txt dependency check #5894
Labels
🧑💻 dev experience
developer experience (excluding CI)
Milestone
Comments
7 tasks
Wumpf
added a commit
that referenced
this issue
Apr 10, 2024
### What * Fixes #5595 Has a few judgment calls on what is no longer needed, but preserves most of what we had. Notably removes `py-requirements` command for the time being - the hope is that #5890 will fix things. (porting it proved difficult) See * #5894 Other things in here: * taplo (toml formatting) was very slow since despite extensive 'exclude' list it looked at too many files. Turned it around to 'include' things and it's a LOT faster now * Updated Ruff & removed last use of blackdoc. The only thing we're not properly catching with this now is too long lines, I figured it's not worth keeping it around just for that. * various cleanups of pixi.toml file: trying to make commands a bit more consistent overall Tested on: * [x] mac * [x] windows ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [rerun.io/viewer](https://rerun.io/viewer/pr/5892) * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5892?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5892?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5892) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
emilk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is NOT the same as
justfile removal (#5892) removed calls to
pip-missing-reqswhich checked for missing requirements. We need to re-establish a similar mechanism.Very related to:
The text was updated successfully, but these errors were encountered: