enable dataframe streaming across FFI

rerun-io · Oct 31, 2024 · d60c862 · d60c862
1 parent 962b7de
commit d60c862
Showing 1 changed file with 0 additions and 18 deletions.
diff --git a/rerun_py/src/dataframe.rs b/rerun_py/src/dataframe.rs
@@ -737,21 +737,12 @@ impl PyRecordingView {
         let metadata = schema.metadata.clone().into_iter().collect();
         let schema = arrow::datatypes::Schema::new(fields).with_metadata(metadata);
 
-        // TODO(jleibs): Need to keep the engine alive
-        /*
         let reader = RecordBatchIterator::new(
             query_handle
                 .into_batch_iter()
                 .map(|batch| batch.try_to_arrow_record_batch()),
             std::sync::Arc::new(schema),
         );
-        */
-        let batches = query_handle
-            .into_batch_iter()
-            .map(|batch| batch.try_to_arrow_record_batch())
-            .collect::<Vec<_>>();
-
-        let reader = RecordBatchIterator::new(batches.into_iter(), std::sync::Arc::new(schema));
 
         Ok(PyArrowType(Box::new(reader)))
     }
@@ -829,21 +820,12 @@ impl PyRecordingView {
         let metadata = schema.metadata.clone().into_iter().collect();
         let schema = arrow::datatypes::Schema::new(fields).with_metadata(metadata);
 
-        // TODO(jleibs): Need to keep the engine alive
-        /*
         let reader = RecordBatchIterator::new(
             query_handle
                 .into_batch_iter()
                 .map(|batch| batch.try_to_arrow_record_batch()),
             std::sync::Arc::new(schema),
         );
-        */
-        let batches = query_handle
-            .into_batch_iter()
-            .map(|batch| batch.try_to_arrow_record_batch())
-            .collect::<Vec<_>>();
-
-        let reader = RecordBatchIterator::new(batches.into_iter(), std::sync::Arc::new(schema));
 
         Ok(PyArrowType(Box::new(reader)))
     }