Prevent the number of columns to do below 12 in demo#48
Open
jccampagne wants to merge 1 commit intorerun-io:mainfrom
Open
Prevent the number of columns to do below 12 in demo#48jccampagne wants to merge 1 commit intorerun-io:mainfrom
jccampagne wants to merge 1 commit intorerun-io:mainfrom
Conversation
This is a quick fix for the demo as it would crash if the DragValue
went below 12.
This is because the groups are hard coded as:
```
egui_table::HeaderRow {
height: self.top_row_height,
groups: vec![0..1, 1..4, 4..8, 8..12],
},
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix for the demo as it would crash if the
DragValuewent below12.This is because the
groupsare hard coded as:This is really a minimal fix, to prevent the demo from crashing (wasm and native).
I think it's more a bug of the demo rather than an issue with the crate, hence this quick fix rather than a more extensive-logic change in the demo...
The app crash in
because
groupswould become stale, because of how their are calculated:index out of boundspanic when modifying table demo column count #23