Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

concepts: add MEF #69

Merged
merged 1 commit into from
Feb 8, 2022
Merged

concepts: add MEF #69

merged 1 commit into from
Feb 8, 2022

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Oct 11, 2021

Co-Authored-by: Peter Weber peter.weber@rero.ch

@rerowep rerowep self-assigned this Oct 11, 2021
@rerowep rerowep force-pushed the wep-mef-concepts branch 6 times, most recently from 5409eaa to abc87e8 Compare October 11, 2021 13:55
iGormilhit
iGormilhit suggested changes Oct 13, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the commit title: concepts: add MEF.

Does it add MEF to concepts, or concepts to MEF? Or is it something else?

rero_mef/agents/mef/api.py Outdated Show resolved Hide resolved
rero_mef/agents/viaf/jsonresolvers/__init__.py Outdated Show resolved Hide resolved
rero_mef/agents/viaf/jsonresolvers/viaf_resolver.py Outdated Show resolved Hide resolved
rero_mef/agents/viaf/jsonresolvers/viaf_resolver.py Outdated Show resolved Hide resolved
rero_mef/agents/viaf/serializers.py Outdated Show resolved Hide resolved
rero_mef/concepts/mef/serializers.py Outdated Show resolved Hide resolved
rero_mef/concepts/mef/serializers.py Show resolved Hide resolved
rero_mef/concepts/serializers.py Outdated Show resolved Hide resolved
rero_mef/concepts/tasks.py Outdated Show resolved Hide resolved
rero_mef/concepts/tasks.py Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-mef-concepts branch 3 times, most recently from 036e633 to ae36423 Compare October 13, 2021 13:46
@rerowep rerowep requested a review from iGormilhit October 13, 2021 13:46
@rerowep rerowep force-pushed the wep-mef-concepts branch 18 times, most recently from 9c2157a to b397c80 Compare October 20, 2021 19:08
@rerowep rerowep force-pushed the wep-mef-concepts branch 4 times, most recently from d0f9971 to 06e3576 Compare October 25, 2021 08:22
@rerowep rerowep requested review from BadrAly and jma October 25, 2021 08:39
@rerowep rerowep force-pushed the wep-mef-concepts branch 2 times, most recently from 3d18926 to c0654a5 Compare October 28, 2021 08:19
@rerowep rerowep force-pushed the wep-mef-concepts branch 3 times, most recently from d5134f2 to eb17121 Compare November 4, 2021 06:09
@rerowep rerowep force-pushed the wep-mef-concepts branch 2 times, most recently from b99b3c8 to d078ba3 Compare November 17, 2021 07:42
@rerowep rerowep force-pushed the wep-mef-concepts branch 3 times, most recently from 3026917 to 86c66e3 Compare December 9, 2021 09:35
@rerowep rerowep removed the request for review from iGormilhit January 11, 2022 10:45
@rerowep rerowep changed the base branch from dev to staging January 31, 2022 07:31
@rerowep rerowep force-pushed the wep-mef-concepts branch 4 times, most recently from c0e7d95 to 4d058e4 Compare February 1, 2022 15:11
@rerowep
concepts: add MEF
fe04751 
* Adds MEF concepts class.
* Splits serialiazers.
* Adds coveralls to github actions.
* Adds tests to increase test coverage.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep merged commit 64ff1a4 into rero:staging Feb 8, 2022
@rerowep rerowep deleted the wep-mef-concepts branch February 17, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit requested changes

@BadrAly BadrAly Awaiting requested review from BadrAly

@jma jma Awaiting requested review from jma

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rerowep @iGormilhit