Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix failing tests #3481

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

PascalRepond
Copy link
Contributor

@PascalRepond PascalRepond commented Oct 9, 2023

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

@PascalRepond PascalRepond changed the title tests: fix redisbeat to v1.2.5 tests: fix redisbeat to <1.2.5 Oct 9, 2023
@PascalRepond PascalRepond force-pushed the rep-tests branch 2 times, most recently from ff67cbe to 15229e0 Compare October 9, 2023 09:03
* Fix redisbeat to <1.2.5
(issue liuliqiang/redisbeat#40).
* Fix patron fixtures expiration dates.
* Fix sip2 patrons expiration dates for tests.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@github-actions github-actions bot added the dev: fixtures Fixtures data used for ils.test and ilsdev.test label Oct 9, 2023
@PascalRepond PascalRepond changed the title tests: fix redisbeat to <1.2.5 tests: fix failing tests Oct 9, 2023
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the commit message as fix partron fixture expiration dates or similar. You can mention the issue for redisbeat :liuliqiang/redisbeat#40

@PascalRepond PascalRepond merged commit 07a8796 into rero:staging Oct 9, 2023
@PascalRepond PascalRepond deleted the rep-tests branch October 9, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: fixtures Fixtures data used for ils.test and ilsdev.test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants