Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix imports #3437

Merged
merged 1 commit into from
Aug 23, 2023
Merged

tests: fix imports #3437

merged 1 commit into from
Aug 23, 2023

Conversation

jma
Copy link
Contributor

@jma jma commented Aug 22, 2023

  • Fixes python import packages order as the check script was broken.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

@jma
tests: fix imports
2316d6f 
* Fixes python import packages order as the check script was broken.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data developers From a developer point of view. f: user management labels Aug 22, 2023
@jma jma marked this pull request as ready for review August 22, 2023 13:41
@jma jma requested review from zannkukai, rerowep and lauren-d August 22, 2023 13:41
@jma jma merged commit 9df2507 into rero:staging Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@rerowep rerowep rerowep approved these changes

@lauren-d lauren-d lauren-d approved these changes

@PascalRepond PascalRepond PascalRepond approved these changes

Assignees
No one assigned
Labels
developers From a developer point of view. f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jma @zannkukai @rerowep @lauren-d @PascalRepond