operation logs: anonymization respects jsonschema #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
f: circulation
PascalRepond
force-pushed
the
rep-operation-logs
branch
2 times, most recently
from
14cbbdd to
cc2748c
Compare
PascalRepond
force-pushed
the
rep-operation-logs
branch
from
cc2748c to
4a1a191
Compare
zannkukai
approved these changes
Jul 25, 2023
rerowep
requested changes
Jul 26, 2023
| record = OperationLog.get_record(uuid) | ||
| LOGGER.info(f'[{idx}/{len(uuids)}] Processing Log#{record.pid} ' | ||
| f'[{record.id}]...') | ||
| record['patron']['name'] = 'anonymized' |
There was a problem hiding this comment.
I think it should be:
record['loan']['patron']['name'] = 'anonymized'
record['loan']['patron']['pid'] = 'anonymized'There was a problem hiding this comment.
Right, thanks!
PascalRepond
force-pushed
the
rep-operation-logs
branch
from
4a1a191 to
17c0eaf
Compare
* Existing invalid data should be corrected manually. Co-authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
force-pushed
the
rep-operation-logs
branch
from
17c0eaf to
b2e22c6
Compare
rerowep
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?