-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
items: update issue related resources #3331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6957fdf
to
57dafc8
Compare
9fb0663
to
2ead7e4
Compare
jma
requested changes
May 22, 2023
rerowep
requested changes
May 22, 2023
22c3a17
to
daa1cc1
Compare
rerowep
requested changes
May 23, 2023
daa1cc1
to
5d39ba5
Compare
5d39ba5
to
9a0a385
Compare
9a0a385
to
bc88a46
Compare
rerowep
approved these changes
May 25, 2023
bc88a46
to
c2bb772
Compare
jma
approved these changes
May 25, 2023
* Removes 'claims_count' fields from `Item` resource. * Removes legacy claim generation code. * Hides some not yet used field into the `Holding` JSONSchema for the `Holding` resource editor * Adds alembic script to remove `claims_count` field * Adds alembic script to update current `claimed` issue to `expected`. * Removes `claimed` status for an issue item. * Adapts the facets configuration for items (no more claimed status --> no more need to have a facet on issue_status). * Adapts CSV item serializers. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
c2bb772
to
08534e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev: DB
Database structure (models.py)
f: data migration
Data migration from a legacy system or a previous version
f: data
About data model, importation, transformation, exportation of data, specific for bibliographic data
f: search
f: serials
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item
resource.Holding
JSONSchema for theHolding
resource editorclaims_count
fieldclaimed
issue toexpected
.claimed
status for an issue item.no more need to have a facet on issue_status).
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com