Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

items: update issue related resources #3331

Merged
merged 1 commit into from
May 25, 2023

Conversation

zannkukai
Copy link
Contributor

  • Removes 'claims_count' fields from Item resource.
  • Removes legacy claim generation code.
  • Hides some not yet used field into the Holding JSONSchema for the
    Holding resource editor
  • Adds alembic script to remove claims_count field
  • Adds alembic script to update current claimed issue to expected.
  • Removes claimed status for an issue item.
  • Adapts the facets configuration for items (no more claimed status -->
    no more need to have a facet on issue_status).
  • Adapts CSV item serializers.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

@github-actions github-actions bot added dev: DB Database structure (models.py) dev: fixtures Fixtures data used for ils.test and ilsdev.test f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: data migration Data migration from a legacy system or a previous version f: search f: serials labels May 9, 2023
@zannkukai zannkukai force-pushed the zan-update-hold-item branch from 6957fdf to 57dafc8 Compare May 9, 2023 16:44
@zannkukai zannkukai self-assigned this May 10, 2023
@zannkukai zannkukai marked this pull request as ready for review May 10, 2023 07:53
@zannkukai zannkukai force-pushed the zan-update-hold-item branch 5 times, most recently from 9fb0663 to 2ead7e4 Compare May 15, 2023 13:48
@zannkukai zannkukai requested review from jma, rerowep and Garfield-fr May 15, 2023 13:50
@zannkukai zannkukai requested review from jma and rerowep May 22, 2023 09:03
@zannkukai zannkukai force-pushed the zan-update-hold-item branch 3 times, most recently from 22c3a17 to daa1cc1 Compare May 22, 2023 11:46
@zannkukai zannkukai force-pushed the zan-update-hold-item branch from daa1cc1 to 5d39ba5 Compare May 24, 2023 07:35
@github-actions github-actions bot removed the dev: fixtures Fixtures data used for ils.test and ilsdev.test label May 24, 2023
@zannkukai zannkukai force-pushed the zan-update-hold-item branch from 5d39ba5 to 9a0a385 Compare May 24, 2023 07:38
@zannkukai zannkukai requested a review from rerowep May 24, 2023 07:38
@zannkukai zannkukai force-pushed the zan-update-hold-item branch from 9a0a385 to bc88a46 Compare May 25, 2023 09:36
@zannkukai zannkukai force-pushed the zan-update-hold-item branch from bc88a46 to c2bb772 Compare May 25, 2023 12:31
* Removes 'claims_count' fields from `Item` resource.
* Removes legacy claim generation code.
* Hides some not yet used field into the `Holding` JSONSchema for the
  `Holding` resource editor
* Adds alembic script to remove `claims_count` field
* Adds alembic script to update current `claimed` issue to `expected`.
* Removes `claimed` status for an issue item.
* Adapts the facets configuration for items (no more claimed status -->
  no more need to have a facet on issue_status).
* Adapts CSV item serializers.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-update-hold-item branch from c2bb772 to 08534e5 Compare May 25, 2023 13:22
@zannkukai zannkukai merged commit 11ffaa0 into rero:US-2509-claim May 25, 2023
@zannkukai zannkukai deleted the zan-update-hold-item branch May 25, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: DB Database structure (models.py) f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: search f: serials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants