Merge US-Permissions to staging
#3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds new professional roles. * Updates data and fixtures. * Reorganizes `Patron.api` file. Co-Authored-by: Lauren-D <laurent.dubois@itld-solutions.be> Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Uses invenio-records-permmissions for CRUD operations. * Adds a generic record permission policy compatible with invenio-records-rest and invenio-records-resources. * Adds actions for patron types. * Adds fixtures and the corresponding cli to the action roles permissions. * Adds two generic permission generators for action role permissions. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Refactoring Organisation policy access using `Permission` framework. * Adapts `PatronType` policy. * Adapts unitest Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Refactoring vendor policy access. * Adapts unitest. Co-Authored-by: Lauren-D <laurent.dubois@itld-solutions.be>
* Refactoring item type policy access. * Adapts unitest. Co-Authored-by: Lauren-D <laurent.dubois@itld-solutions.be>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Refactoring contibution policy access. * Adapts unitest. Co-Authored-by: Lauren-D <laurent.dubois@itld-solutions.be>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Refactoring circulation policies policy access. * Adapts unitest. Co-Authored-by: Lauren-D <laurent.dubois@itld-solutions.be>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch> Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Refactors Budget permission policies resource. * Refactors AcqAccount permission policies resource. * Refactors AcqOrder permission policies resource. * Refactors AcqOrderLine permission policies resource. * Refactors AcqReceipt permission policies resource. * Refactors AcqInvoice permission policies resource. * Cleans uni-tests to remove unnecessary tests. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Refactors `Collection` resource permission policy. * Refactors `Template` resource permission policy. * Adapts and cleans unitests. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Uses invenio-record-permissions to limit access to LocalField resource on CRUD operations. * Fixes LocalField duplicate detection * Adapts uni-tests Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Use `invenio-record-permissions` policies to manage REST permissions policy on `Patron` resource. This policy also restrict some change on `roles` field depending of the connected user. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Adding a `permissions` setting into the logged_user API. This is useful to UI to know if it's necessary to show/hide some elements. * Removes actions from `pyproject.toml` to load them when the application is loaded. This was an issue for CLI application. * Use cache system to store `ActionNeed` loading result to improve performance.. * Creates API to manage permissions. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Create an API to expose permssion for a specific patron pid. * Add action to allow acquisition account transfer. * Updates copyright dates * Fix roles managements behavior for `Patron` resources. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Creates marshmallow schema for template resources. * Controls "public" template creation through REST API. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Use Marshmallow schema to control `Patron` resources through API. The `role` field is now controlled to limit changes depending to current connected user. * Renames `User.get_by_id()` to `User.get_record()` * Improves code coverage * Include `public-holdings-items` CSS into document detail-view * Fixes policies related to `Template` resource. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
github-actions
bot
added
dev: DB
github-actions
bot
added
f: data
PascalRepond
requested changes
Feb 7, 2023
* Changing the json schema to use the multicheckbox type for the role field. * Fix the Alembic role migration script. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch> Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
US-Permissions
branch
from
bc9fae8 to
6d7bdc7
Compare
PascalRepond
approved these changes
Feb 7, 2023
benerken
approved these changes
Feb 7, 2023
lauren-d
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And then... crying for rebase