Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

items: issue sorting & late issue schedule task #3226

Merged
merged 1 commit into from
Feb 7, 2023
Merged

items: issue sorting & late issue schedule task #3226

merged 1 commit into from
Feb 7, 2023

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Jan 26, 2023 •
edited
Loading

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

Migration script

🚨 Update mapping for item resource 🚨

from rero_ils.modules.items.api import ItemsIndexer, ItemsSearch

query = ItemsSearch().filter('term', type='issue').source(False)
uuids = [hit.meta.id for hit in query.scan()]

indexer = ItemsIndexer()
indexer.bulk_index(uuids)
_, (indexer_count, error_count) = indexer.process_bulk_queue()
print(f'{indexer_count} items indexed, {error_count} errors')

@zannkukai zannkukai self-assigned this Jan 26, 2023
@github-actions github-actions bot added dev: DB Database structure (models.py) f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: data migration Data migration from a legacy system or a previous version f: search f: serials labels Jan 26, 2023
@zannkukai zannkukai force-pushed the zan-fix-issue-2921 branch 4 times, most recently from 280bb56 to 9de52d5 Compare January 30, 2023 12:26
@zannkukai zannkukai mentioned this pull request Jan 30, 2023
Merged
@zannkukai zannkukai requested review from rerowep and vgranata February 2, 2023 15:11
@zannkukai zannkukai marked this pull request as ready for review February 6, 2023 09:04
@zannkukai zannkukai requested a review from lauren-d February 6, 2023 09:05
@zannkukai zannkukai requested a review from rerowep February 6, 2023 13:39
lauren-d
lauren-d approved these changes Feb 6, 2023
View reviewed changes
@jma jma self-requested a review February 7, 2023 09:09
@zannkukai
items: issue sorting & late issue schedule task
e9f15a7 
* Adds new `sort_date` for issue item. Used to sort issue regardless
  expected date.
* Adds extensions on `Item` resource to control/manage issue status and
  issue sort_date.
* Updates `late_issue_process` to include already created issue if
  expected_date has been manually changed by manager.
* Item/Holding code refactoring.
* Closes rero#2921.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai merged commit 5f2116d into rero:staging Feb 7, 2023
@zannkukai zannkukai deleted the zan-fix-issue-2921 branch February 7, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benerken benerken benerken approved these changes

@rerowep rerowep rerowep approved these changes

@lauren-d lauren-d lauren-d approved these changes

@vgranata vgranata vgranata approved these changes

@jma jma Awaiting requested review from jma

Assignees

@zannkukai zannkukai

Labels
dev: DB Database structure (models.py) f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: search f: serials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify for serial issues a delivery date different from the expected date
5 participants
@zannkukai @benerken @rerowep @lauren-d @vgranata