Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatronTransaction: facets & serialization #3160

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

zannkukai
Copy link
Contributor

  • Adds facet configuration for PatronTransactionEvent resource.
  • Simplifies default_facet_factory method.
  • Generalizes nested aggregations serialization.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

@github-actions github-actions bot added dev: DB Database structure (models.py) f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version f: permissions Concerns the rights management f: search labels Nov 13, 2022
@zannkukai zannkukai self-assigned this Nov 22, 2022
@zannkukai zannkukai force-pushed the zan-ptre-serializing branch 5 times, most recently from 63b9847 to 9a6fa95 Compare November 23, 2022 12:52
@zannkukai zannkukai marked this pull request as ready for review November 23, 2022 14:15
@zannkukai zannkukai requested a review from lauren-d November 23, 2022 14:15
@zannkukai zannkukai force-pushed the zan-ptre-serializing branch from 9a6fa95 to ae14464 Compare November 28, 2022 08:58
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Dec 1, 2022

  • : MD(12.01): wrong menu name for 'Inventory list'.

  • REP: [acceptance criteria] There is no sort options for the list.

  • REP: [acceptance criteria] The list is not filtered by today's date by default.

  • REP: The translations for categories and types are unclear ("en retard" should be "frais de retard").

  • REP: It is unclear what the difference is between category and subtype, why do we need these two separated facets ?

  • REP: [acceptance criteria] There is no fee detailed view. --> MD: US would cost more. Not blocking.

  • BER: [not blocking but boring] In the CSV, the amount is displayed with a dot "2.0" (in place of "2,0"). The Spreadsheet doesn't consider it as a number but as TEXT. So, the staff can't sum the total amount of fees in the table. (An option to change on Spreadsheet side perhaps ?)
    - MD (2/12) still the case.
    Ex LibreOffice
    image
    Ex Excel :
    image

  • MD: library name not well displayed when there is no result --> not linked to the pr. Issue to create
    image

  • REP: UX: Contrast should be higher between text and background in brief view info badges (librarian, library, type). Could also be better in the fees summary facet.
    image

* Adds facet configuration for PatronTransactionEvent resource.
* Simplifies `default_facet_factory` method.
* Generalizes nested aggregations serialization.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-ptre-serializing branch from b0603bd to f67c826 Compare December 2, 2022 10:25
@zannkukai zannkukai merged commit 8dc2b3f into rero:staging Dec 14, 2022
@zannkukai zannkukai deleted the zan-ptre-serializing branch December 14, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: DB Database structure (models.py) f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version f: permissions Concerns the rights management f: search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants