-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PatronTransaction: facets & serialization #3160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63b9847
to
9a6fa95
Compare
lauren-d
reviewed
Nov 24, 2022
9a6fa95
to
ae14464
Compare
ae14464
to
b0603bd
Compare
* Adds facet configuration for PatronTransactionEvent resource. * Simplifies `default_facet_factory` method. * Generalizes nested aggregations serialization. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
b0603bd
to
f67c826
Compare
lauren-d
approved these changes
Dec 5, 2022
benerken
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev: DB
Database structure (models.py)
f: circulation
Concerns the circulation interface or backend
f: data migration
Data migration from a legacy system or a previous version
f: permissions
Concerns the rights management
f: search
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_facet_factory
method.Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com