Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

items: add new fields to inventory list #2975

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Jun 27, 2022

Co-Authored-by: Aly Badr aly.badr@rero.ch

How to Test:

@BadrAly BadrAly self-assigned this Jun 27, 2022
@github-actions github-actions bot added dev: DB Database structure (models.py) f: data migration Data migration from a legacy system or a previous version labels Jun 27, 2022
@BadrAly BadrAly force-pushed the baa-item-inv-list-csv branch from 427d692 to 043a575 Compare June 27, 2022 13:10
@BadrAly BadrAly force-pushed the baa-item-inv-list-csv branch from 043a575 to 812ce13 Compare June 27, 2022 13:20
@BadrAly BadrAly added enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend bug Breaks something but is not blocking client request Issue reported by production libraries and removed f: data migration Data migration from a legacy system or a previous version dev: DB Database structure (models.py) labels Jun 27, 2022
@BadrAly BadrAly force-pushed the baa-item-inv-list-csv branch from 812ce13 to e63f1cc Compare June 28, 2022 08:28
@BadrAly BadrAly requested a review from zannkukai June 28, 2022 08:28
@github-actions github-actions bot added dev: DB Database structure (models.py) f: data migration Data migration from a legacy system or a previous version and removed f: circulation Concerns the circulation interface or backend labels Jun 28, 2022
@PascalRepond
Copy link
Contributor

PascalRepond commented Jun 28, 2022

Tests

  • document_series_statement and document_edition_statement are not exported (column stays empty)
  • document_local_fields not exported (column stays empty)
  • temporary_item_type not exported (column stays empty)
  • Item 1611 has a checkout date but last_transaction_date is empty. Why?
  • LAU: It is better to have all dates in the same format.
  • REP 29.06: Items of type issue are not exported anymore. Try filtering by "serial" in AOSTE-CANT1, there are 79 issues in the interface but the file is empty. Cannot test the issue related columns.
    • JD 29.06 : The "Late issues" export doesn't work either (no data export).
  • REP 29.06 : item_status stays empty
  • NPR 29.06: within document and item local fields: if more than one value, values should be concatenated with | as for the other fields.

@benerken
Copy link
Contributor

benerken commented Jun 28, 2022

Great job ! Thank you.

Cosmetic remark:

  • please move the first 2 columns (item_pid and item_create_date) and try group them with the other Item columns.
    => The purpose is to get Document info, then Item info, then loan infos.

@BadrAly BadrAly force-pushed the baa-item-inv-list-csv branch from e63f1cc to 6c34a52 Compare June 28, 2022 14:36
* Fixes rero#2704
* Fixes rero#2793

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly force-pushed the baa-item-inv-list-csv branch from 6c34a52 to 7742c60 Compare June 30, 2022 08:55
@BadrAly BadrAly merged commit b9bdf04 into rero:v1.13 Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries dev: DB Database structure (models.py) enhancement Improvement of an existing feature f: data migration Data migration from a legacy system or a previous version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants