Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifications: fix pickup name for booking #2290

Merged
merged 1 commit into from
Aug 11, 2021
Merged

notifications: fix pickup name for booking #2290

merged 1 commit into from
Aug 11, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented Aug 11, 2021

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@jma
notifications: fix pickup name for booking
786ffce 
* Closes: rero#2262.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@github-actions github-actions bot added f: notifications f: public ui Public interface, as opposed to the professional interface labels Aug 11, 2021
@jma jma requested review from lauren-d and BadrAly August 11, 2021 13:17
@jma jma marked this pull request as ready for review August 11, 2021 13:26
@jma jma merged commit 21e46e8 into rero:dev Aug 11, 2021
@jma jma deleted the maj-fix-notifications branch January 13, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadrAly BadrAly BadrAly approved these changes

@lauren-d lauren-d lauren-d approved these changes

Assignees
No one assigned
Labels
f: notifications f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong pick-up location name in the booking notification
3 participants
@jma @BadrAly @lauren-d