circulation: load legacy transactions #1856
Merged
+174
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
added
the
f: data migration
BadrAly
force-pushed
the
baa-load-virtua-loans-cli
branch
from
4090c69 to
5aeb1d0
Compare
BadrAly
requested review from
rerowep,
zannkukai,
benerken,
iGormilhit,
lauren-d,
jma and
Garfield-fr
Garfield-fr
approved these changes
Apr 29, 2021
lauren-d
approved these changes
Apr 29, 2021
zannkukai
reviewed
Apr 29, 2021
There was a problem hiding this comment.
Sound confusing for me to have some legacy load method from Virtua into the RERO project.
In the best of the world, I think this CLI should be extracted from RERO-ILS github project to be integrated into a possible "VirtuaToReroMigration" project
@zannkukai I agree with you, we create a new project MigrateToReroILS when we have the first Alma library :-)
benerken
approved these changes
Apr 29, 2021
BadrAly
force-pushed
the
baa-load-virtua-loans-cli
branch
from
5aeb1d0 to
b218456
Compare
iGormilhit
reviewed
Apr 29, 2021
BadrAly
force-pushed
the
baa-load-virtua-loans-cli
branch
from
b218456 to
2c3274c
Compare
rerowep
reviewed
Apr 29, 2021
zannkukai
approved these changes
Apr 29, 2021
BadrAly
force-pushed
the
baa-load-virtua-loans-cli
branch
2 times, most recently
from
acc6f15 to
591f209
Compare
rerowep
reviewed
May 1, 2021
* Creates a CLI to load prepared Virtua circulation transactions into RERO ILS. Three transaction types are allowed: checkouts, requests and fines. Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly
force-pushed
the
baa-load-virtua-loans-cli
branch
from
591f209 to
876768b
Compare
rerowep
approved these changes
May 2, 2021
iGormilhit
approved these changes
May 3, 2021
jma
approved these changes
May 3, 2021
| def check_missing_fields(transaction, transaction_type): | ||
| """Return list of missing fields for a given transaction type. | ||
|
|
||
| transaction: the json transaction record. |
There was a problem hiding this comment.
Should be: :param, see https://thomas-cokelaer.info/tutorials/sphinx/docstring_python.html for more details. Please check similar cases.
| item: the item record. | ||
| """ | ||
| if transaction_type == 'checkout': | ||
| transaction['state'] = 'ITEM_ON_LOAN' |
There was a problem hiding this comment.
The alternative can be to have a dict with new fields and use the update dict method.
| records = read_json_record(infile) | ||
| else: | ||
| file_data = json.load(infile) | ||
| text = 'Loading Virtua transactions of type {transaction_type}'.format( |
There was a problem hiding this comment.
you can use f'' here, please check other cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RERO ILS. Three transaction types are allowed: checkouts, requests and
fines.
Co-Authored-by: Aly Badr aly.badr@rero.ch
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/us/2011?milestone=289558
Code review check list