Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

holdings: fix several bugs related to version 1.0.0 #1681

Merged
merged 1 commit into from
Feb 8, 2021
Merged

holdings: fix several bugs related to version 1.0.0 #1681

merged 1 commit into from
Feb 8, 2021

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Feb 6, 2021

  • Hides masked holdings from public interface.
  • Indexes parent document after holdings updates.
  • Adapts units testing.

Co-Authored-by: Aly Badr aly.badr@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@BadrAly BadrAly added the bug Breaks something but is not blocking label Feb 6, 2021
@BadrAly BadrAly self-assigned this Feb 6, 2021
iGormilhit
iGormilhit approved these changes Feb 8, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the component of the commit message title, I think that holdings is fine.

Otherwise, this PR is ok for me. Thanks.

@iGormilhit iGormilhit added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: public ui Public interface, as opposed to the professional interface f: search labels Feb 8, 2021
@iGormilhit iGormilhit added this to the v1.0.0 milestone Feb 8, 2021
holdings: fix several bugs related to version 1.0.0
6289218 
* Hides masked holdings from public interface.
* Indexes parent document after holdings updates.
* Adapts units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly changed the title bugs: fix several bugs related to version 1.0.0 holdings: fix several bugs related to version 1.0.0 Feb 8, 2021
@BadrAly BadrAly merged commit 1e9f227 into rero:dev Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

Assignees

@BadrAly BadrAly

Labels
bug Breaks something but is not blocking f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: public ui Public interface, as opposed to the professional interface f: search
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BadrAly @iGormilhit @zannkukai