Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public ui: better document type facet #1680

Merged
merged 1 commit into from
Mar 9, 2021
Merged

public ui: better document type facet #1680

merged 1 commit into from
Mar 9, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 5, 2021 •
edited by iGormilhit
Loading

Co-Authored-by: Peter Weber peter.weber@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Feb 5, 2021
zannkukai
zannkukai reviewed Feb 6, 2021
View reviewed changes
rero_ils/modules/documents/serializers.py Outdated Show resolved Hide resolved
rero_ils/modules/documents/serializers.py Outdated Show resolved Hide resolved
rero_ils/modules/documents/serializers.py Outdated Show resolved Hide resolved
rero_ils/modules/documents/serializers.py Outdated Show resolved Hide resolved
rero_ils/modules/documents/serializers.py Outdated Show resolved Hide resolved
@iGormilhit iGormilhit added this to the v1.1.0 milestone Feb 9, 2021
iGormilhit
iGormilhit suggested changes Feb 9, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it fix? What was broken?

@rerowep
Copy link
Contributor Author

rerowep commented Feb 9, 2021

What does it fix? What was broken?

Actually nothing was broken, the function of the document type was just not understandable.

@rerowep rerowep changed the title public ui: fix document facet public ui: better document type facet Feb 9, 2021
@rerowep rerowep force-pushed the wep-fix-facets branch 3 times, most recently from 5e549d2 to d41dd06 Compare February 18, 2021 13:38
@rerowep rerowep force-pushed the wep-fix-facets branch 2 times, most recently from cb0904f to 09fe6a1 Compare February 25, 2021 08:14
jma
jma reviewed Feb 25, 2021
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit message is quite poor. Can you please add more details?

rero_ils/modules/documents/utils.py Outdated Show resolved Hide resolved
@iGormilhit iGormilhit modified the milestones: v1.1.0, v1.2.0 Mar 1, 2021
@rerowep rerowep force-pushed the wep-fix-facets branch 2 times, most recently from 8f8f968 to a64a3c4 Compare March 3, 2021 10:13
@rerowep rerowep force-pushed the wep-fix-facets branch 2 times, most recently from f53f293 to aeccc42 Compare March 4, 2021 12:04
@rerowep rerowep requested a review from jma March 4, 2021 12:05
@rerowep rerowep force-pushed the wep-fix-facets branch 2 times, most recently from 76cf55e to 648231d Compare March 8, 2021 08:35
jma
jma reviewed Mar 8, 2021
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to add some tests? Perhaps it is already covered by the current tests?

rero_ils/modules/utils.py Show resolved Hide resolved
@rerowep
public ui: better document type facet
26ab2ff 
* The functionality of the document main, sub type facet for documents with multiple types was not clear.
Now we display only the sub types accossiated with the main type in the facet.
* closes rero#1697
* Adds memoized decorator.
  (https://flask-caching.readthedocs.io/en/latest/api.html#flask_caching.Cache.memoize)

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep merged commit 5ccf99b into rero:dev Mar 9, 2021
@rerowep rerowep deleted the wep-fix-facets branch March 9, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@BadrAly BadrAly BadrAly approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma jma approved these changes

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

Assignees

@rerowep rerowep

Labels
f: search
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rerowep @jma @iGormilhit @zannkukai @BadrAly @lauren-d