Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documents: implement document type #1593

Closed
wants to merge 6 commits into from
Closed

documents: implement document type #1593

wants to merge 6 commits into from

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jan 8, 2021

Co-Authored-by: Peter Weber peter.weber@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Jan 8, 2021
@rerowep rerowep marked this pull request as draft January 8, 2021 12:54
@rerowep rerowep force-pushed the wep-#1933-document-type branch 18 times, most recently from 46b04c6 to 4e18f5e Compare January 12, 2021 20:18
@iGormilhit iGormilhit added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Jan 13, 2021
@iGormilhit iGormilhit added this to the v1.0.0 milestone Jan 13, 2021
@iGormilhit iGormilhit changed the title document: document type documents: implement document type Jan 13, 2021
@rerowep rerowep force-pushed the wep-#1933-document-type branch 2 times, most recently from b7eb5ad to 156b5e7 Compare January 14, 2021 08:51
@lauren-d lauren-d force-pushed the wep-#1933-document-type branch from 156b5e7 to 0e5bde4 Compare January 14, 2021 12:45
@rerowep rerowep force-pushed the wep-#1933-document-type branch 2 times, most recently from d0a34f4 to 7eb4dac Compare January 15, 2021 13:30
@AoNoOokami AoNoOokami mentioned this pull request Jan 18, 2021
Merged
7 tasks
@rerowep
dependencies: upgrade invenio to version 3.4
132280e 
* Adds count display during holding creation.
* Cleans ill_request_form.html file.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep force-pushed the wep-#1933-document-type branch 10 times, most recently from eacc6af to 39d21ef Compare January 21, 2021 17:01
Alicia Zangger and others added 3 commits January 25, 2021 12:43
@AoNoOokami
notification: improve password reset notifications
cddfaeb 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@zannkukai
items: Adapts JSON schema for temporary item type
e313f40 
Adapts the item JSON schema and ES mapping to introduce the 'temporary
item type` entry.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai
items: use temporary item_type for circulation
3fb0cf4 
* Uses a temporary item_type (or circulation category) for circulation
  operations (checkout, extend, renew) if it's defined and valid on an
  item.
* Creates a new cron tasks to clear the obsolete temporary item_type.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@rerowep rerowep force-pushed the wep-#1933-document-type branch 2 times, most recently from b8c5013 to 48635a6 Compare January 25, 2021 13:01
@rerowep rerowep marked this pull request as ready for review January 25, 2021 16:18
@rerowep rerowep requested review from jma and BadrAly January 25, 2021 16:19
@rerowep @lauren-d
document: document type
7079b96 
* Adds `c0verd` decorator and uses it to cache covers.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

* Adds subtype subfacet for documents.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>

* Adapts SIP2 types.

Co-Authored-by: Lauren-D <laurent.dubois@itld-solutions.be>
@rerowep rerowep force-pushed the wep-#1933-document-type branch from 48635a6 to 7079b96 Compare January 25, 2021 18:25
@rerowep rerowep closed this Jan 25, 2021
@benerken
Copy link
Contributor

benerken commented Jan 25, 2021 •
edited by AoNoOokami
Loading

In the professional view, logged as Jean:

  • when I try to VIEW the document 815 (docsubtype_other_book), I get an error 500. I don't know if it's linked to this US (?)
    image

  • Same problem with an article : document 540.

  • - [ ] When I list the requests, some lines are not loaded. The little spinner loops and the console returns an error 500.
    This is related to error 500 mentioned above.

  • When I create a new document (with type/ subtype) and try to save it "As a template", I get an error 500.

  • Inventory List: When I export a list in CSV, the column "Document Type" contains main type and subtype at the same time. It could be improved to split value in 2 columns (not blocking but enhancement).
    For now, it's boring to use the list with values like this
    [{'subtype': 'docsubtype_other_book', 'main_type': 'docmaintype_book'}, {'subtype': 'docsubtype_manga', 'main_type': 'docmaintype_comic'}]
    --

  • Inventory List: (depending of the amount of work needed) is it possible to add a new facet for DocType/SubType ?

@pronguen
Copy link
Contributor

pronguen commented Jan 26, 2021 •
edited by AoNoOokami
Loading

  • For Cantook e-books, a tab "Online access" is now displayed. It was not the case before: why? I think it is not necessary.
  • In the editor:
    • The subtype is optional. It should be required (if the corresponding main type has subtypes).
    • If it is easy to set: put main type and subtype on the same line to save vertical space.
  • Is it normal that the temporary circulation category is already deployed? The field is mandatory in the item editor...
  • I cannot save templates anymore. The button works but has no effect.

See also Benoit's comments

@AoNoOokami
Copy link
Contributor 

* [ ]  Is it normal that the temporary circulation category is already deployed? The field is mandatory in the item editor...

Ping @zannkukai I think.

@ThierryClavel
Copy link

the maintype comic should have 2 subtypes : comic and manga : in the following exemple there is manga and other book https://ilsdev.test.rero.ch/global/search/documents?q=&page=1&size=10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

@lauren-d lauren-d Awaiting requested review from lauren-d

@zannkukai zannkukai Awaiting requested review from zannkukai

@jma jma Awaiting requested review from jma

@BadrAly BadrAly Awaiting requested review from BadrAly

Assignees

@rerowep rerowep

Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@rerowep @benerken @pronguen @AoNoOokami @ThierryClavel @iGormilhit @zannkukai