-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
circulation: allow 'less than one day' checkout #1477
Conversation
529d6a3
to
c49b589
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message proposition:
circulation: allow 'less than one day' checkout
* Changes minimum checkout duration in the circulation policy JSON
schema to allow 'less than one day' checkouts.
Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
d90aa92
to
e585e0d
Compare
e585e0d
to
63081b8
Compare
3d62ed8
to
bd23d7a
Compare
bd23d7a
to
35fd084
Compare
35fd084
to
378f95a
Compare
|
I don't think this is related to the current US. Edit: see rero/rero-ils-ui#442
It seems that the default ci-po is used. This may be an existing bug that is highlighted with this US. to be confirmed by @BadrAly Edit: this was a bug coming from the current work. The ci-po updated were not correctly indexed.
It is the original behaviour of the editor. I can make additional corrections but it will take some time. The restriction on ptty-itty combination that was not working is related to the issue above (due date).
Actually, when we uncheck the last item type, it unchecks the patron type automatically. And when the patron type is not checked, the item types are not displayed. I can change the behaviour to let the item types, but the patron type has to be unchecked manually to allow the form saving. |
378f95a
to
58eb240
Compare
34ae0a6
to
f6685f0
Compare
* Changes minimum checkout duration in the circulation policy JSON schema to allow 'less than one day' checkouts. * Allows a print in the console when a record is reindexed for debug. * Corrects russian dolls script to use webpack integration instead of invenio bundles. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
f6685f0
to
d4e4814
Compare
schema to allow 'less than one day' checkouts.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
Task 1881 of US1759
https://tree.taiga.io/project/rero21-reroils/us/1759?milestone=277700
Dependencies
My PR depends on the following
rero-ils-ui
's PR(s):N/A
How to test?
Please do code review only.
Code review check list