Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document: improve provision activity date fields #1432

Merged
merged 1 commit into from
Nov 27, 2020
Merged

document: improve provision activity date fields #1432

merged 1 commit into from
Nov 27, 2020

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Nov 11, 2020 •
edited
Loading

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

To close issue mentioned above.

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

N/A

How to test?

See issue description.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@AoNoOokami AoNoOokami self-assigned this Nov 11, 2020
@AoNoOokami AoNoOokami added this to the v0.15.0 milestone Nov 11, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1844-improve-date-fields-provision-activity branch from 52d5722 to bc8e922 Compare November 11, 2020 09:27
iGormilhit
iGormilhit reviewed Nov 12, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component part of the commit message title could be document instead of json schema.

@iGormilhit iGormilhit added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data wording When text is concerned, label, message, actions… labels Nov 12, 2020
@iGormilhit iGormilhit changed the title json schema: improve provision activity date fields document: improve provision activity date fields Nov 17, 2020
@AoNoOokami AoNoOokami requested review from zannkukai and removed request for rerowep November 25, 2020 14:22
@AoNoOokami AoNoOokami force-pushed the zaa-#1844-improve-date-fields-provision-activity branch from bc8e922 to c071278 Compare November 25, 2020 14:24
json schema: improve provision activity date fields
e50caaf 
* Improves title and description of dates in provision activity.
* Closes rero#1424.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami force-pushed the zaa-#1844-improve-date-fields-provision-activity branch from c071278 to e50caaf Compare November 27, 2020 09:41
@AoNoOokami AoNoOokami merged commit 0d04924 into rero:dev Nov 27, 2020
@AoNoOokami AoNoOokami deleted the zaa-#1844-improve-date-fields-provision-activity branch December 4, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadrAly BadrAly BadrAly approved these changes

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

Assignees

@AoNoOokami AoNoOokami

Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data wording When text is concerned, label, message, actions…
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

Fields startDate and endDate in provisionActivity title and description should be improved
4 participants
@AoNoOokami @iGormilhit @zannkukai @BadrAly