Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2.6 #273

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Drop support for Python 2.6 #273

merged 1 commit into from
Apr 17, 2017

Conversation

jdufresne
Copy link
Member

I would humbly like to suggest requests-oauthlib drop support for Python
2.6.

The last release of Python 2.6 was 2013-10-29, over 3 years ago. It is
no longer receiving security fixes.

https://www.python.org/dev/peps/pep-0361/

The pip project itself has recently dropped support for 2.6. Their
numbers estimate that Python 2.6 accounts for ~2% of their downloads.

pypa/pip#4343

For projects that still use Python 2.6, they can continue to pip install
an older version.

I've tried my best to remove as much 2.6 specific code as I can,
including the 'Programming Language :: Python :: 2.6' trove classifier
from setup.py. I've also removed Travis CI testing, which should result
in faster testing and fewer wasted resources.

Code removed:

  • setup.py cleanups due to fewer version complications
  • Testing configuration
  • Logging workaround for missing NullHandler
  • Removed unittest2 dependency and monkey patching
  • StringIO import errors

Thanks for considering.

@coveralls
Copy link

coveralls commented Apr 17, 2017

Coverage Status

Coverage increased (+0.7%) to 87.689% when pulling 7c44b05 on jdufresne:drop-py26 into 6d341c1 on requests:master.

I would humbly like to suggest requests-oauthlib drop support for Python
2.6.

The last release of Python 2.6 was 2013-10-29, over 3 years ago. It is
no longer receiving security fixes.

https://www.python.org/dev/peps/pep-0361/

The pip project itself has recently dropped support for 2.6. Their
numbers estimate that Python 2.6 accounts for ~2% of their downloads.

pypa/pip#4343

For projects that still use Python 2.6, they can continue to pip install
an older version.

I've tried my best to remove as much 2.6 specific code as I can,
including the 'Programming Language :: Python :: 2.6' trove classifier
from setup.py. I've also removed Travis CI testing, which should result
in faster testing and fewer wasted resources.

Code removed:

- setup.py cleanups due to fewer version complications
- Testing configuration
- Logging workaround for missing NullHandler
- Removed unittest2 dependency and monkey patching
- StringIO import errors

Thanks for considering.
@coveralls
Copy link

coveralls commented Apr 17, 2017

Coverage Status

Coverage increased (+0.7%) to 87.689% when pulling 84ad78c on jdufresne:drop-py26 into 6d341c1 on requests:master.

Copy link
Member

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good tome, let's do it.

@Lukasa Lukasa merged commit c7862a0 into requests:master Apr 17, 2017
@jdufresne jdufresne deleted the drop-py26 branch October 21, 2017 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants