Skip to content

drop clone module in favor of JSON.parse & JSON.stringify combo for better performance #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simov merged 3 commits into from
May 20, 2015
Merged

drop clone module in favor of JSON.parse & JSON.stringify combo for better performance #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b43b28
drop `clone` module in favor of `JSON.parse` & `JSON.stringify` combo…
ahmadnassri Apr 30, 2015
0aab79c
use a wrapper for JSON.stringify
ahmadnassri May 1, 2015
d356cec
stringify-clone should be a dependency (not a devDependency)
ahmadnassri May 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# request-debug [![Build status](https://img.shields.io/travis/request/request-debug.svg?style=flat)](https://travis-ci.org/request/request-debug) [![npm package](http://img.shields.io/npm/v/request-debug.svg?style=flat)](https://www.npmjs.org/package/request-debug)

This Node.js module provides an easy way to monitor HTTP(S) requests performed
by the [`request` module](https://github.com/mikeal/request), and their
by the [`request` module](https://github.com/request/request), and their
responses from external servers.

## Usage
Expand Down Expand Up @@ -83,15 +83,15 @@ Unless you provide your own function as the second parameter to the
following:

```js
{ request:
{ request:
{ debugId: 1,
uri: 'http://nylen.tv/digest.php',
method: 'GET',
headers: { host: 'nylen.tv' } } }
{ auth:
{ auth:
{ debugId: 1,
statusCode: 401,
headers:
headers:
{ date: 'Mon, 20 Oct 2014 03:34:58 GMT',
server: 'Apache/2.4.6 (Debian)',
'x-powered-by': 'PHP/5.5.6-1',
Expand All @@ -101,16 +101,16 @@ following:
connection: 'Keep-Alive',
'content-type': 'text/html' },
uri: 'http://nylen.tv/digest.php' } }
{ request:
{ request:
{ debugId: 1,
uri: 'http://nylen.tv/digest.php',
method: 'GET',
headers:
headers:
{ authorization: 'Digest username="admin", realm="Restricted area", nonce="544482e2556d9", uri="/digest.php", qop=auth, response="e833c7fa52e8d42fae3ca784b96dfd38", nc=00000001, cnonce="ab6ff3dd95a0449e990a6c8465a6bb26", opaque="cdce8a5c95a1427d74df7acbf41c9ce0"',
host: 'nylen.tv' } } }
{ response:
{ response:
{ debugId: 1,
headers:
headers:
{ date: 'Mon, 20 Oct 2014 03:34:58 GMT',
server: 'Apache/2.4.6 (Debian)',
'x-powered-by': 'PHP/5.5.6-1',
Expand Down
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var clone = require('clone');
var clone = require('stringify-clone');

var debugId = 0;

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@
"should" : "~4.0.4"
},
"dependencies" : {
"clone" : "~0.1.18"
"stringify-clone": "^1.0.0"
}
}