Skip to content

Conversation

@dan-nl
Copy link

@dan-nl dan-nl commented Mar 7, 2016

No description provided.

@eiriksm
Copy link
Member

eiriksm commented Mar 7, 2016

Hm. Probably someone else might want to chime in here, but how about using process.version instead? Would make for a way easier diff to read.

Also, feels like a try/catch would also produce a strange output if the actual block would start to fail on something else. The output would show the failed line inside the catch block, while the problem really is in the try block, so that is where we would want it to fail, right?

My 2 cents at least. Nice catch with the failing tests, by the way!

@dan-nl
Copy link
Author

dan-nl commented Mar 11, 2016

ja, i wasn’t sure how to best address the test failure. the try/catch worked and was a straight forward adjustment i considered at that moment, but i agree that it appears to be overkill. still, the travis output makes it easy to identify exactly where there’s a problem: look for expected and actual highlights in the output.

if i get some more free time i’ll take a look at adjusting the tests in the way you suggest above.

@dan-nl dan-nl closed this Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants