Skip to content

Adds displayName property to oidc authentication method #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2023
Merged

Adds displayName property to oidc authentication method #6096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b033a5
Adds displayName property to oidc authentication method
gueldenstone Jan 27, 2023
323db0d
fix: update displayName prop
NGPixel Jan 29, 2023
18a88a1
fix: use blank display name in oidc auth
NGPixel Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion server/modules/authentication/oidc/authentication.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ module.exports = {
providerKey: req.params.strategy,
profile: {
...profile,
email: _.get(profile, '_json.' + conf.emailClaim)
email: _.get(profile, '_json.' + conf.emailClaim),
displayName: _.get(profile, conf.displayNameClaim, ''),
}
})
if (conf.mapGroups) {
Expand Down
13 changes: 10 additions & 3 deletions server/modules/authentication/oidc/definition.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,21 +49,28 @@ props:
default: email
maxWidth: 500
order: 7
displayNameClaim:
type: String
title: Display Name Claim
hint: Field containing the user display name
default: displayName
maxWidth: 500
order: 8
mapGroups:
type: Boolean
title: Map Groups
hint: Map groups matching names from the groups claim value
default: false
order: 8
order: 9
groupsClaim:
type: String
title: Groups Claim
hint: Field containing the group names
default: groups
maxWidth: 500
order: 9
order: 10
logoutURL:
type: String
title: Logout URL
hint: (optional) Logout URL on the OAuth2 provider where the user will be redirected to complete the logout process.
order: 10
order: 11