Skip to content

Conversation

@uyu423
Copy link

@uyu423 uyu423 commented Nov 25, 2022

@auto-assign auto-assign bot requested a review from NGPixel November 25, 2022 21:36
@NGPixel
Copy link
Member

NGPixel commented Nov 25, 2022

While that may fix code blocks, you're now breaking inline code. Your PR should address both, not one in favor of the other.

@uyu423
Copy link
Author

uyu423 commented Nov 26, 2022

Hi @NGPixel.

I tested the inline code markdown syntax you mentioned.
But I don't know what kind of "breaking" you're talking about.
I attach two screenshots. One is the original version, and one is my PR version.

If I missed something please tell me again.

I am using your wikijs project very well.
Thank you

original

image

in my PR

image

@uyu423
Copy link
Author

uyu423 commented Dec 22, 2022

@NGPixel hello?

@NGPixel
Copy link
Member

NGPixel commented Feb 17, 2023

Closing in favor of #6108

@NGPixel NGPixel closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants