Skip to content

Conversation

@jordanjean
Copy link
Contributor

@jordanjean jordanjean commented Nov 18, 2021

Description

This PR aims at making possible to add extra volumes and extra volumes mounts in Wiki.js container. It is really useful to add CA certificates in /etc/ssl/certs for instance.

Test

Deploy the chart with these values and check the mount in the Wiki.js container.

[...]

volumeMounts:
  - name: my-volume
    mountPath: /mydir
    readOnly: true
volumes:
  - name: my-volume
    hostPath:
      path: /mydir

@auto-assign auto-assign bot requested a review from NGPixel November 18, 2021 14:13
Copy link

@sajidakram62l sajidakram62l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev/helm/values.yaml

@NGPixel
Copy link
Member

NGPixel commented Dec 15, 2021

Please restore the spaces that were stripped at the end of some lines in the README. These are not mistakes and are necessary to force line returns.

@jordanjean
Copy link
Contributor Author

Hello, sure, I restored the spaces.

@NGPixel NGPixel merged commit 8d42075 into requarks:dev Feb 5, 2022
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants