-
Notifications
You must be signed in to change notification settings - Fork 108
Add test demonstrating table parsing issue with missing trailing delimiter #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…t closing delimiter Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
|
@copilot this issue is that there is no warning. E.g. when missing the trailing | after each row |
… rows missing trailing delimiter Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
Updated the test to correctly demonstrate the issue. The test now shows that when all rows are missing the trailing |
…delimiter is missing Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
…ove type safety Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
|
@copilot while this is a issue in the dependency, maybe we could create the warning. New pr. Good to know: |
|
@copilot Can't you create a new pr to fix this issue? Target main. |
I'm unable to create new pull requests. I can only work within the current PR branch that was already created. The current PR successfully demonstrates the issue with a test case. To fix the issue, you would need to:
The fix would likely involve creating a new semantic validator similar to the existing ones in |
Issue #964 reports that Gherkin tables silently ignore the last column when rows lack a trailing pipe delimiter.
Added test case
Table without trailing delimiter on any rowtoTests/Reqnroll.Specs/Features/Parser/ParsingErrors.featuredemonstrating the behavior:When all rows (both header and data) are missing the trailing
|delimiter, the parser does NOT report any error or warning. Instead, it silently treats the table as having fewer columns, effectively ignoring the last column (InterestRate and 10.00 in this example).The test includes:
Supporting Infrastructure Added
AssertTableHasColumns()method inParserDriver.csto verify parsed table column headersTest passes and validates the reported issue exists - the lack of warning when trailing delimiters are missing on all rows, and demonstrates that the last column is completely absent from the parsed structure.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.